Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing legacy StaticLint #97

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

bergel
Copy link
Collaborator

@bergel bergel commented Oct 23, 2024

No description provided.

@bergel bergel linked an issue Oct 23, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 23, 2024

Static code analyzer report

Output of the StaticLint.jl code analyzer. 🫵Want to contribute?🫵 RelationalAI Style Guide for Julia
Report creation time (UTC): (2024-11-05T09:38:31.667)

  • Line 538, column 9: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/src/interface.jl
  • Line 544, column 13: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/src/interface.jl
  • Line 63, column 12: Use tin(item,collection) instead of the Julia's in or . raicode/src/interface.jl
  • Line 167, column 12: Use tin(item,collection) instead of the Julia's in or . raicode/src/interface.jl
  • Line 374, column 5: Use tin(item,collection) instead of the Julia's in or . raicode/src/interface.jl
  • Line 85, column 16: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 140, column 43: Use $(x) instead of $x (explanation). raicode/src/linting/extended_checks.jl
  • Line 375, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 431, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 434, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 435, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 475, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 571, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 583, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 616, column 26: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 31, column 16: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 43, column 16: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 987, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1043, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1104, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1287, column 21: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
    🚨In total, 13 rule violations and 0 PR reviewer recommendation are found over 5 Julia files🚨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaning: Remove the use of Server.jl
1 participant